Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR based on the work done on #23. It allows to use a ref in a property object, as defined by the OpenAPI v3 spec.
I think it is obvious that I am duplicating the code that was in
Swagger::Objects::SchematoSwagger::Objects::Property. Actually in the OpenAPI v3 spec they are both the same. Thepropertiesdict isHash(String, Schema).So I would like to propose to merge those two types. For the user facing API we can keep the
Swagger::ObjectandSwagger::Propertydistinction, but for the OpenAPI generation I don't think it brings any advantage.