add support for "lightbulbs" connected to Hue#142
Open
lobeck wants to merge 1 commit intoikalchev:devfrom
Open
add support for "lightbulbs" connected to Hue#142lobeck wants to merge 1 commit intoikalchev:devfrom
lobeck wants to merge 1 commit intoikalchev:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #142 +/- ##
=======================================
Coverage 52.08% 52.08%
=======================================
Files 15 15
Lines 1342 1342
Branches 138 138
=======================================
Hits 699 699
Misses 628 628
Partials 15 15 |
ikalchev
requested changes
Jul 29, 2018
Owner
ikalchev
left a comment
ikalchev
left a comment
There was a problem hiding this comment.
Hi and thanks for the contrib. Also sorry for the delay! Can you leave just the accessory in this file so that users can just use the main.py and import this module?
| from pyhap.accessory_driver import AccessoryDriver | ||
| from pyhap.const import CATEGORY_LIGHTBULB | ||
|
|
||
| logging.basicConfig(level=logging.INFO) |
Owner
There was a problem hiding this comment.
Maybe leave this to the module that starts HAP, e.g. the main.py
Owner
There was a problem hiding this comment.
If you decide to remove it, can you use logger = logging.getLogger(__name__)
|
|
||
| self.id = id | ||
|
|
||
| def __setstate__(self, state): |
Owner
There was a problem hiding this comment.
This method is not needed now (if you don't plan to pickle the accessory)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a basic accessory discovering lightbulbs connected to a Hue Bridge and exposes them to HomeKit.