Skip to content

Conversation

@piyushryn
Copy link
Contributor

@piyushryn piyushryn commented Jan 13, 2026

Changes:

  • Version bumped to 6.0.1
  • tslib moved from dependencies to peerDependencies with version constraint ^2.3.0
  • Added uninstall step for angular sdk to automatically handle version bumps

@piyushryn piyushryn requested a review from Copilot January 13, 2026 12:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package version from 6.0.0 to 6.0.1 and refactors the dependency structure by moving tslib from dependencies to peerDependencies.

Changes:

  • Version bumped to 6.0.1
  • tslib moved from dependencies to peerDependencies with version constraint ^2.3.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@piyushryn piyushryn requested a review from manu4543 January 14, 2026 05:08
@piyushryn
Copy link
Contributor Author

Not Removing tslib because:

  • TypeScript's importHelpers option tells the compiler to import helper functions from tslib rather than emit them inline
  • ng-packagr analyzes the TypeScript config and compiled output
  • It automatically adds tslib to dependencies because the compiled code requires it at runtime
  • Changing this behavior would lead to an increase in bundle size as all the TypeScript helpers would be injected inline

Additionally, npm's dependency resolution will ensure only one copy of the library exists in the final node_modules, as Angular Core v14 to v21 already depends on the same tslib version (^2.3.0).

@piyushryn piyushryn closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant