Add imagej.projections.project_stack()

[CellKai]

No description provided.

[ehrenfeu]

Waiting for imcf/imcf-fiji-mocks#3 to be completed & 🔀 merged, in order for the tests 🧪 to pass.

[codecov]

Codecov Report

Attention: Patch coverage is 16.12903% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (devel@e0c2108). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/imcflibs/imagej/projections.py	16.12%	26 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             devel      #40   +/-   ##
========================================
  Coverage         ?   28.33%           
========================================
  Files            ?       24           
  Lines            ?     1394           
  Branches         ?        0           
========================================
  Hits             ?      395           
  Misses           ?      999           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ehrenfeu]

Please see the in-line comments / requests.

[ehrenfeu]

Please have the function summary on the same line as the opening quotes """ and make it less than 88 characters in total.

Try to use minimalist phrasing, this is really meant to be a one-liner that conveys the idea of the function, for example this one could be:

def project_stack(imp, projected_dimension, projection_type, ops, ds, cs):
    """Project along a defined axis using the given projection type.

   [bla...]
   """

[ehrenfeu]

Make sure docstrings do not exceed the 88 chars line length, you may want to consider the Rewrap Revived extension for VS Code for doing this.

[ehrenfeu]

❤️ Thanks a lot!

Unlike what I said when leaving the office a while ago, there's nothing else to fix (I was confusing other linting issues fully unrelated to this PR... 🤦🏼‍♂️).

Ready to be merged! 🔀 🚀

[CellKai]

Hooray \o/ :D

[ehrenfeu]

@CellKai the merge was happening in a slightly unexpected way (GitHub only offered a rebase or squash), so no idea what the status in your fork of the repo would be now (after my rebase-merge).

In case your repo still contains the branch that was used to start this PR, you may delete the branch now.