Skip to content

Conversation

@lguerard
Copy link
Contributor

No description provided.

@ehrenfeu ehrenfeu added enhancement New feature or request unit testing A unit test should be created next-release Issues blocking the next release next-coding-session Look into during the next CS. labels Mar 18, 2025
@ehrenfeu ehrenfeu added this to the 1.5.0 milestone Mar 18, 2025
@ehrenfeu ehrenfeu moved this to In progress in imcflibs Mar 18, 2025
@ehrenfeu ehrenfeu moved this from In progress to In review in imcflibs Mar 25, 2025
@ehrenfeu
Copy link
Member

The remaining linting error is only for BDV related files.

And with merging #39 into devel, and devel into this branch in f0a1c9c, the remaining linting errors have vanished!

💪🏼 🚀

Copy link
Member

@ehrenfeu ehrenfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining open requests (plus the one attached below to this very comment):

  • docstring for calculate_mean_and_stdv(): #49 (comment)
  • move pad_number() to strtools: #49 (comment)
  • rename apply_background_subtraction to rollingball_background_subtraction or apply_rollingball_bg_subtraction: #49 (comment)

@imcf imcf deleted a comment from codecov bot Mar 25, 2025
@ehrenfeu ehrenfeu force-pushed the coding-session/2025-03-11 branch from 69d9851 to f0a1c9c Compare March 25, 2025 22:20
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 7.05882% with 237 lines in your changes missing coverage. Please review.

Project coverage is 25.06%. Comparing base (b02198e) to head (8cef7bf).
Report is 73 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/bioformats.py 2.17% 90 Missing ⚠️
src/imcflibs/imagej/misc.py 20.00% 56 Missing ⚠️
src/imcflibs/imagej/omerotools.py 0.00% 38 Missing ⚠️
src/imcflibs/imagej/processing.py 0.00% 31 Missing ⚠️
src/imcflibs/imagej/labelimage.py 0.00% 16 Missing ⚠️
src/imcflibs/imagej/objects3d.py 0.00% 3 Missing ⚠️
src/imcflibs/pathtools.py 50.00% 2 Missing ⚠️
src/imcflibs/imagej/shading.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #49      +/-   ##
==========================================
- Coverage   28.19%   25.06%   -3.14%     
==========================================
  Files          24       25       +1     
  Lines        1426     1656     +230     
==========================================
+ Hits          402      415      +13     
- Misses       1024     1241     +217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehrenfeu
Copy link
Member

@lguerard how about we merge this PR now and address the remaining tasks in separate issues later on?

Remaining open requests (plus the one attached below to this very comment):

* docstring for `calculate_mean_and_stdv()`: [Add more methods following the coding session of 2025 03 11 #49 (comment)](https://github.com/imcf/python-imcflibs/pull/49#discussion_r2012334834)

* move `pad_number()` to `strtools`: [Add more methods following the coding session of 2025 03 11 #49 (comment)](https://github.com/imcf/python-imcflibs/pull/49#discussion_r2004100289)

* rename `apply_background_subtraction` to `rollingball_background_subtraction` or `apply_rollingball_bg_subtraction`: [Add more methods following the coding session of 2025 03 11 #49 (comment)](https://github.com/imcf/python-imcflibs/pull/49#discussion_r2010350151)

@ehrenfeu ehrenfeu merged commit bf97721 into imcf:devel Mar 26, 2025
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in imcflibs Mar 26, 2025
@ehrenfeu ehrenfeu changed the title Add more methods following the coding session of 2025 03 11 Follow-ups from the coding session 2025-03-11 Mar 26, 2025
@ehrenfeu ehrenfeu changed the title Follow-ups from the coding session 2025-03-11 Follow-ups from the coding session on 2025-03-11 Mar 26, 2025
@lguerard lguerard deleted the coding-session/2025-03-11 branch March 26, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request next-coding-session Look into during the next CS. next-release Issues blocking the next release unit testing A unit test should be created

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants