Use pre-releases of imcf-fiji-mocks in Python2 setups
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: this was created in order to facilitate the project setup using Python 2 🐍🪦 but is currently UNUSED as this opens Pandora's box 🪤 of versions specified via 🎭 Poetry but incompatible with Python 2 etc.
ehrenfeu
added
unit testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #51 +/- ##
=======================================
Coverage 28.81% 28.81%
=======================================
Files 24 24
Lines 1388 1388
=======================================
Hits 400 400
Misses 988 988 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
changed the title
imcf-fiji-mocks in Python2 setups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a hard-coded version was installed by the Python2 wrapper/setup script, which had to be updated manually when changes were done to
pyproject.toml- and hence was mostly forgotten:python-imcflibs/scripts/py2-pytest.sh
Lines 105 to 115 in d3b0cca
This was fine as long as all required changes to
imcf-fiji-mockswere published as stable releases (as thepip installcommand would use the latest stable one), but would fail as soon as changes to the mocks were only available in pre-releases. This is fixed through this PR by installing that package using pip's--preflag.