🎨 Improve type shrinking and apply it to type_map#328
Merged
elbeno merged 2 commits intointel:mainfrom Feb 12, 2026
Merged
Conversation
Problem: - `expand_t` assumes its argument is shrunk. It should be the identity function if the argument is not shrunk, but expand the argument if it is shrunk. Solution: - Add a `shrinkwrap` wrapper to distinguish types which have been shrunk from regular types.
Problem: - `type_map` can get large, leading to symbol bloat and compilation slowdown. Solution: - Shrink the size of `type_map` symbols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
expand_tassumes its argument is shrunk. It should be the identity function if the argument is not shrunk, but expand the argument if it is shrunk.type_mapcan get large, leading to symbol bloat and compilation slowdown.Solution:
shrinkwrapwrapper to distinguish types which have been shrunk from regular types.type_mapsymbols.