feat(range): add class and expose parts for dual knobs for custom styling #30941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
commented
Jan 29, 2026
Member
Author
There was a problem hiding this comment.
This change is required otherwise it won't match knob when it has knob knob-a.
brandyscarney
commented
Jan 29, 2026
Member
Author
There was a problem hiding this comment.
I renamed the classes assigned to knob-handle from range-knob-a to range-knob-handle-a to match what they are actually applied to.
brandyscarney
commented
Jan 29, 2026
| configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | ||
| test.describe(title('range: customization'), () => { | ||
| test('should be customizable', async ({ page }) => { | ||
| await page.goto(`/src/components/range/test/custom`, config); |
Member
Author
There was a problem hiding this comment.
I removed the screenshots here in favor of checking that the styles are applied to the right element when the part is styled.
brandyscarney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29862
What is the current behavior?
Range exposes a single part for both knobs & pins. This makes it impossible to style the knobs/pins differently when dual knobs is enabled.
What is the new behavior?
range-dual-knobsto the host element whendualKnobsis enabledknob-handle-a- The container element for the lower/left knob. Only available whendualKnobsistrue.knob-handle-b- The container element for the upper/right knob. Only available whendualKnobsistrue.pin-a- The counter that appears above the lower/left knob. Only available whendualKnobsistrue.pin-b- The counter that appears above the upper/right knob. Only available whendualKnobsistrue.knob-a- The visual knob element for the lower/left knob. Only available whendualKnobsistrue.knob-b- The visual knob element for the upper/right knob. Only available whendualKnobsistrue.pressed- Added to the knob-handle, knob, and pin that is currently being pressed to drag. Only one set has this part at a time.focused- Added to the knob-handle, knob, and pin that currently has focus. Only one set has this part at a time.Does this introduce a breaking change?
Other information