Skip to content

Conversation

Copy link

Copilot AI commented Feb 3, 2026

The dark palette feature for test environments was already implemented but marked with a TODO comment. This removes the marker.

Changes

  • Removed TODO(FW-4004) from core/scripts/testing/scripts.js line 139

Implementation

The dark palette loads when ?palette=dark is specified in test URLs:

// Detects palette parameter, loads theme tokens, enables dark mode
if (paletteName === 'dark' && theme.palette?.dark) {
  theme.palette.dark.enabled = 'always';
}

This functionality is already tested across multiple components (textarea, toast, datetime, action-sheet, select-popover) using configs({ palettes: ['light', 'dark'] }).

Related

High contrast palettes (FW-4005) follow the same pattern at lines 142 and 145.

Original prompt

Work on TODO: Implement dark palette (from core/scripts/testing/scripts.js)

Created from VS Code via the GitHub Pull Request extension.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Feb 3, 2026 0:17am

Request Review

Co-authored-by: thetaPC <13530427+thetaPC@users.noreply.github.com>
Co-authored-by: thetaPC <13530427+thetaPC@users.noreply.github.com>
Copilot AI changed the title [WIP] Add dark palette implementation to testing scripts Remove TODO(FW-4004): Dark palette implementation complete Feb 3, 2026
Copilot AI requested a review from thetaPC February 3, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants