Skip to content

Made IOPubThread constructor backward compatible #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 3 commits into from
Jan 30, 2026
+6 −6
Merged

Made IOPubThread constructor backward compatible #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6afd867
Made IOPubThread constructor backward compatible
JohanMabille Jan 30, 2026
775a741
Merge branch 'main' into iostream_compatibility
JohanMabille Jan 30, 2026
d0c9d20
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipykernel/inprocess/ipkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class InProcessKernel(IPythonKernel):

@default("iopub_thread")
def _default_iopub_thread(self):
thread = IOPubThread(self._underlying_iopub_socket, self.session)
thread = IOPubThread(self._underlying_iopub_socket, session=self.session)
thread.start()
return thread

Expand Down
4 changes: 2 additions & 2 deletions ipykernel/iostream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class IOPubThread:
whose IO is always run in a thread.
"""

def __init__(self, socket, session=None, pipe=False):
def __init__(self, socket, pipe=False, session=False):
"""Create IOPub thread

Parameters
Expand Down Expand Up @@ -518,7 +518,7 @@ def __init__(
DeprecationWarning,
stacklevel=2,
)
pub_thread = IOPubThread(pub_thread, self.session)
pub_thread = IOPubThread(pub_thread, session=self.session)
pub_thread.start()
self.pub_thread = pub_thread
self.name = name
Expand Down
2 changes: 1 addition & 1 deletion ipykernel/kernelapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def init_iopub(self, context):
self.iopub_port = self._bind_socket(self.iopub_socket, self.iopub_port)
self.log.debug("iopub PUB Channel on port: %i", self.iopub_port)
self.configure_tornado_logger()
self.iopub_thread = IOPubThread(self.iopub_socket, self.session, pipe=True)
self.iopub_thread = IOPubThread(self.iopub_socket, pipe=True, session=self.session)
self.iopub_thread.start()
# backward-compat: wrap iopub socket API in background thread
self.iopub_socket = self.iopub_thread.background_socket
Expand Down
4 changes: 2 additions & 2 deletions tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def ctx():
def iopub_thread(ctx):
session = Session()
with ctx.socket(zmq.PUB) as pub:
thread = IOPubThread(pub, session)
thread = IOPubThread(pub, session=session)
thread.start()

yield thread
Expand Down Expand Up @@ -156,7 +156,7 @@ def subprocess_test_echo_watch():
# use PUSH socket to avoid subscription issues
with zmq.Context() as ctx, ctx.socket(zmq.PUSH) as pub:
pub.connect(os.environ["IOPUB_URL"])
iopub_thread = IOPubThread(pub, session)
iopub_thread = IOPubThread(pub, session=session)
iopub_thread.start()
stdout_fd = sys.stdout.fileno()
sys.stdout.flush()
Expand Down