Rename and refactor bootstrap, implement basic provisioning functions #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagner-de
force-pushed
the
feat/provisioning-logic
branch
2 times, most recently
from
4f5a453 to
9e59f4a
Compare
swagner-de
force-pushed
the
feat/provisioning-logic
branch
from
9e59f4a to
24203e1
Compare
hardikdr
added
the
area/metal-automation
swagner-de
force-pushed
the
feat/provisioning-logic
branch
2 times, most recently
from
d34c54d to
e5aa346
Compare
This renames `DeviceSpec.Bootstrap` to `Provisioning` in order to have a unified naming. We also implement a ProvisioningProvider interface and state transitionings in the device controller.
swagner-de
force-pushed
the
feat/provisioning-logic
branch
2 times, most recently
from
1b1d271 to
bb719f3
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
felix-kaestner
approved these changes
Dec 19, 2025
| // +required | ||
| Endpoint Endpoint `json:"endpoint"` | ||
|
|
||
| // Bootstrap is an optional configuration for the device bootstrap process. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Bootstrap is an optional configuration for the device bootstrap process. | |
| // Provisioning is an optional configuration for the device provisioning process. |
nit: this comment should be updated.
| if activeProv == nil { | ||
| err := errors.New("device went into provisioning completed phase, but no active provisioning found") | ||
| log.Error(err, "Failed to finalize provisioning") | ||
| return ctrl.Result{}, err |
Contributor
There was a problem hiding this comment.
Suggested change
| return ctrl.Result{}, err | |
| return ctrl.Result{}, reconcile.TerminalError(err) |
We should use a reconcile.TerminalError as there is no point in retrying on this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
DeviceSpec.BootstraptoProvisioningin order to have aunified naming. We also implement a ProvisioningProvider interface and
state transitionings in the device controller.