utils - fix: Improve error handling for getOrSet#1553
Merged
jaredwray merged 9 commits intojaredwray:mainfrom Jan 28, 2026
Merged
utils - fix: Improve error handling for getOrSet#1553jaredwray merged 9 commits intojaredwray:mainfrom
jaredwray merged 9 commits intojaredwray:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2401 2416 +15
Branches 530 535 +5
=========================================
+ Hits 2401 2416 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@nrutman - thanks for sending this in. I am wondering if we should use different wording such as |
Contributor
Author
|
@jaredwray, I'm happy to use whatever identifiers you think are best. Note that the |
Contributor
Author
|
@jaredwray, this is ready for another review. I renamed the contexts. |
Owner
|
@nrutman - thanks so much for this. We should have it live in the next week or so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR satisfies the requests in #1554:
logicalandcacheoptions tothrowErrorsoption ongetOrSet().getOrSet()fail.Note
Note that for some reason the
memoize.tsfile used tabs where other files in this repo used 2 spaces. This PR replaces the tabs with spaces, so disabling whitespace in the diff will probably be helpful.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is an improvement to the existing
getOrSet()functionality.