Ammend more consistent naming using CharSequence instead of String#1073
Open
ralfs-gutmanis wants to merge 1 commit intojknack:masterfrom
Open
Ammend more consistent naming using CharSequence instead of String#1073ralfs-gutmanis wants to merge 1 commit intojknack:masterfrom
ralfs-gutmanis wants to merge 1 commit intojknack:masterfrom
Conversation
Add condition to avoid needlessly creating String object in format if the value already is instanceof CharSequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
As part of security requirements - to avoid leaving traces of very sensitive data in memory, we are trying to clear memory as much as it is possible. All instance of java.lang.String are immutable and stay in memory until Garbage Collector deletes them.
Solution
Avoid needlessly calling .toString() if the value already is a CharSequence