Add support for escaping raw expressions (TVAR)#1086
Open
JonMcPherson wants to merge 25 commits intojknack:masterfrom
Open
Add support for escaping raw expressions (TVAR)#1086JonMcPherson wants to merge 25 commits intojknack:masterfrom
JonMcPherson wants to merge 25 commits intojknack:masterfrom
Conversation
Create a new field for internal, unresolved storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1084
Escaping raw expressions (TVAR) is supported by Handlebars.js, but Handlebars.java currently only supports escaping normal expressions (VAR). It is a simple fix to also support escaping raw expressions by updating
varEscapeto first check with the extra curly bracket in the delimiters likestart + "{"andend + "}", then otherwise check with the normal start and end delimiters like before. The visitEscape function doesn't need to change since the ignoring behavior is the same, we only care to drop the escape character.