Add a additonal version of Logger::init for initialisation with more meaningful literals#8
Open
sdicke wants to merge 2 commits intojuzzlin:masterfrom
sdicke:master
Open
Add a additonal version of Logger::init for initialisation with more meaningful literals#8sdicke wants to merge 2 commits intojuzzlin:masterfrom sdicke:master
sdicke wants to merge 2 commits intojuzzlin:masterfrom
sdicke:master
Conversation
Owner
|
Hi, What is the problem this PR solves as there are still only two states just like in the current implementation? I kind of like the approach, but wouldn't like to add another init function that does exactly the same thing.. |
juzzlin
reviewed
Aug 13, 2019
| EpochMicroseconds | ||
| }; | ||
|
|
||
| enum class Append : bool |
Owner
There was a problem hiding this comment.
A better name for this enum could be something like OpenMode and probably with values Create and Append. In my opinion Append::Append looks a bit weird.
juzzlin
requested changes
Aug 13, 2019
|
|
||
| void Logger::init(std::string filename, Append append) | ||
| { | ||
| Logger::init(filename, static_cast<bool>(append)); |
Owner
There was a problem hiding this comment.
Here it would be better to use switch statement instead of casting the enum and relying on some specific value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.