This repository was archived by the owner on Jan 13, 2024. It is now read-only.
Integrate Npp's dark mode APIs#104
Closed
rdipardo wants to merge 3 commits intokbilsted:masterfrom
rdipardo:feat/dark-mode-integration
Closed
Integrate Npp's dark mode APIs#104rdipardo wants to merge 3 commits intokbilsted:masterfrom rdipardo:feat/dark-mode-integration
rdipardo wants to merge 3 commits intokbilsted:masterfrom
rdipardo:feat/dark-mode-integration
Conversation
Exposes the APIs available since Npp v8.4.1 This lets plugins customize WinForm controls that can't be reached by Npp's native dark mode theming
molsonkiko
added a commit
to molsonkiko/NotepadPlusPlusPluginPack.Net
that referenced
this pull request
Apr 28, 2023
Based on kbilsted#104 Rdipardo did all the hard work here, this is just a refinement. This makes it easy for plugin makers to apply dark mode to all forms. Rather than having to individually select themes to apply for each control, sensible defaults are applied based on each control's type. This PR also allows the color changes to propagate recursively to a form's child forms, if it has any.
Owner
|
should we go with #107 ? |
Author
|
Go for it.
…On Fri., May 19, 2023, 12:37 p.m. Kasper B. Graversen, < ***@***.***> wrote:
should we go with #107
<#107> ?
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOCFPANTRH4LVTIPBI4XOXLXG6OUNANCNFSM6AAAAAAXMEC5K4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
molsonkiko
added a commit
to molsonkiko/NotepadPlusPlusPluginPack.Net
that referenced
this pull request
Jun 20, 2023
Based on kbilsted#104 Rdipardo did all the hard work here, this is just a refinement. This makes it easy for plugin makers to apply dark mode to all forms. Rather than having to individually select themes to apply for each control, sensible defaults are applied based on each control's type. This PR also allows the color changes to propagate recursively to a form's child forms, if it has any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the APIs available since Npp v8.4.1
This lets plugins customize WinForm controls that can't be reached by Npp's native dark mode theming
Before
After
Fixes:
Discussion: https://community.notepad-plus-plus.org/topic/24403/darkmode-doesn-t-stylize-all-plugin-controls-on-docked-window-groupbox-panel-labels-etc