Update Go version to 1.25.4. #918
Conversation
This commit updates the Go version to 1.25.4 across the project. The dev/tools/update-golang script has also been improved to update the go directive in go.mod files.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FelipeYepez The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
|
@FelipeYepez: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # The go directive should be the major.minor version | ||
| major_minor_version = ".".join(new_version.split(".")[:2]) | ||
| def fn(line): | ||
| # Replace lines like `go 1.24.0` |
There was a problem hiding this comment.
Q: do we need to? I thought this was the language version, and the toolchain directive is what matters, but I could be wrong.
There was a problem hiding this comment.
My initial thinking was that while the toolchain directive is what's strictly required for the build, updating the go directive to 1.25 is a standard practice that signals the module is now compatible with the Go 1.25 language version and can start using its new features.
My understanding was that it's generally best practice to keep the language version aligned with the new toolchain, but I could be mistaken on that. I'm happy to change it back and only update the toolchain if that's the preferred convention
There was a problem hiding this comment.
We can let the approvers chime in (e.g .@cheftako ). In theory it might make it harder to backport code changes, in practice it seems more likely that we forget to update this vesion :-). But we could also just leave the language version as-is until we need a newer version.
For a library, it's more important to be compatible with older language versions. I think maybe as this is not a library, we should just use the latest and stay auto-updated (i.e. I think what you've done here is correct)
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
3 participants
This commit updates the Go version to 1.25.4 across the project. The dev/tools/update-golang script has also been improved to update the go directive in go.mod files.