Skip to content

Conversation

@08volt
Copy link
Member

@08volt 08volt commented Dec 12, 2025

  • change ensure LB return type to include both Status and Annotations
  • added tests to check annotations are correctly set on both Internal and External L4 LBs
  • added Merge Annotation helper function and tests for it

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2025
@08volt
Copy link
Member Author

08volt commented Dec 12, 2025

/retest

1 similar comment
@08volt
Copy link
Member Author

08volt commented Dec 13, 2025

/retest

@08volt 08volt force-pushed the annotations branch 2 times, most recently from 094de2d to 7a5e1b3 Compare December 15, 2025 11:22
@08volt 08volt force-pushed the annotations branch 3 times, most recently from b295e75 to 2df856e Compare December 15, 2025 13:56
@08volt 08volt force-pushed the annotations branch 2 times, most recently from 924e589 to ecc7961 Compare December 15, 2025 14:44
Comment on lines +107 to +112
// BackendServiceKey is the annotation key used by l4 controller to record
// GCP Backend service name.
BackendServiceKey = ServiceStatusPrefix + "/" + BackendServiceResource
// TargetPoolKey is the annotation key used by l4 controller to record
// GCP Target pool name.
TargetPoolKey = ServiceStatusPrefix + "/" + TargetPoolResource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to export anything outside these Target Pools or Backend Service? I feel like adding more than necessary will limit our potential to add or modify stuff in the future.

For example in ingress-gce names for NetLB Forwarding Rules didn't take into account protocols, which made the design more difficult, as it needed to consider more cases. If we start exporting more than necessary and someone starts depending on those values we might be boxed in. We won't even know if someone depends on this values.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 08volt
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants