-
Notifications
You must be signed in to change notification settings - Fork 247
Add Resource Annotations to L4 LB Service #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
094de2d to
7a5e1b3
Compare
b295e75 to
2df856e
Compare
924e589 to
ecc7961
Compare
| // BackendServiceKey is the annotation key used by l4 controller to record | ||
| // GCP Backend service name. | ||
| BackendServiceKey = ServiceStatusPrefix + "/" + BackendServiceResource | ||
| // TargetPoolKey is the annotation key used by l4 controller to record | ||
| // GCP Target pool name. | ||
| TargetPoolKey = ServiceStatusPrefix + "/" + TargetPoolResource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to export anything outside these Target Pools or Backend Service? I feel like adding more than necessary will limit our potential to add or modify stuff in the future.
For example in ingress-gce names for NetLB Forwarding Rules didn't take into account protocols, which made the design more difficult, as it needed to consider more cases. If we start exporting more than necessary and someone starts depending on those values we might be boxed in. We won't even know if someone depends on this values.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 08volt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Uh oh!
There was an error while loading. Please reload this page.