Skip to content

update the ips for Q4 2025 and expand to all AWS regions #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Dec 13, 2025
Merged

update the ips for Q4 2025 and expand to all AWS regions #315

k8s-ci-robot merged 2 commits into from
Dec 13, 2025
+8,933 −3,395

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Nov 30, 2025

I updated the IPs to the most recent ranges. Last update was 5 months ago.

I also tweaked the codegen so now you can run make codegen from the root of the repo and it will pull the latest ip ranges & generate the go file.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Nov 30, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2025
@upodroid
Copy link
Member Author

upodroid commented Nov 30, 2025

/hold

sa-west1 needs to be routed somewhere, I see #312 but I'm working on the S3/AR expansion project so we'll have a bucket for all the regions in Dec 2025

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2025
@upodroid
Copy link
Member Author

upodroid commented Nov 30, 2025 •
edited
Loading

As we start backfilling the regions in kubernetes/k8s.io#8819, the tests will pass. For example, af-south-1 was backfilled and enabled for replication today.

@upodroid upodroid force-pushed the update-ip-ranges-q4-2025 branch 2 times, most recently from 4a7a646 to a2d0ef0 Compare November 30, 2025 23:35
@upodroid upodroid changed the title update the ips for Q4 2025 and fix up some scripts update the ips for Q4 2025 and expand to all AWS regions Nov 30, 2025
@upodroid upodroid force-pushed the update-ip-ranges-q4-2025 branch from a2d0ef0 to 012f74b Compare December 13, 2025 02:36
@upodroid
Copy link
Member Author

upodroid commented Dec 13, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2025
xmudrii
xmudrii approved these changes Dec 13, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a2c05c4 into kubernetes:main Dec 13, 2025
7 checks passed
BenTheElder
BenTheElder reviewed Dec 13, 2025
View reviewed changes
hack/make-rules/codegen.sh
curl -fLo 'pkg/net/cloudcidrs/internal/ranges2go/data/aws-ip-ranges.json' 'https://ip-ranges.amazonaws.com/ip-ranges.json'
curl -fLo 'pkg/net/cloudcidrs/internal/ranges2go/data/gcp-cloud.json' 'https://www.gstatic.com/ipranges/cloud.json'

# AWS adds IP ranges for unreleased regions which we want to exclude
Copy link
Member

@BenTheElder BenTheElder Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, these will eventually be released, and then we will not detect them as AWS ...

We should really just add a mapping for these regions ...

Copy link
Member Author

@upodroid upodroid Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add the ranges, the unreleased region needs to be mapped somewhere or the tests fail.

I enabled Storage Lens so we can figure out whats actually happening with our buckets such as rps, bandwidth etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

@GenPage GenPage Awaiting requested review from GenPage

+1 more reviewer

@BenTheElder BenTheElder BenTheElder left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@upodroid @k8s-ci-robot @BenTheElder @xmudrii