Skip to content

Conversation

@yanhuan0802
Copy link

@yanhuan0802 yanhuan0802 commented Dec 14, 2025

Description

This PR fixes incorrect kubectl attach commands in the image volume documentation.

The original commands used kubectl attach -it image-volume bash, which:

  1. Includes an invalid bash argument (kubectl attach doesn't accept command arguments)
  2. Cannot provide interactive shell access when the container's main process is sleep infinity

All instances have been replaced with kubectl exec -it image-volume -- bash, which correctly:

  • Starts a new bash process inside the container
  • Provides proper interactive terminal access
  • Follows Kubernetes best practices for container interaction

Files modified:

  • content/en/docs/tasks/configure-pod-container/image-volumes.md (2 occurrences)
  • content/en/blog/_posts/2025-04-29-image-volume-beta/index.md (1 occurrence)

Issue

#53623

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Dec 14, 2025
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language labels Dec 14, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @yanhuan0802!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2025
@netlify
Copy link

netlify bot commented Dec 14, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a4c463b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/693f6eb70537cf0008b0ab3a
😎 Deploy Preview https://deploy-preview-53616--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanhuan0802 Thanks for your contribution. It appears that this PR includes changes to files across multiple languages English and Chinese. However, docs follows different processes for each localization, and and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. After the merge of the English content, we could create separate pull request for the remaining language(s). I hope this suggestion is helpful.

@dipesh-rawat
Copy link
Member

Explicit hold until this PR only covers one language
(Ok to unhold once that's done)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2025
@yanhuan0802 yanhuan0802 force-pushed the bugfix-exec-to-image-volume-container branch from 0e3bf5d to a4c463b Compare December 15, 2025 02:13
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2025
@yanhuan0802
Copy link
Author

yanhuan0802 commented Dec 15, 2025

@yanhuan0802 Thanks for your contribution. It appears that this PR includes changes to files across multiple languages English and Chinese. However, docs follows different processes for each localization, and and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. After the merge of the English content, we could create separate pull request for the remaining language(s). I hope this suggestion is helpful.

@dipesh-rawat Updated. PTAL

@windsonsea
Copy link
Member

/remove-language zh
/remove-area localization
/unhold

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language area/localization General issues or PRs related to localization labels Dec 15, 2025
@stmcginnis
Copy link
Contributor

Is there a reason for switching from attach to exec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants