-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Fix incorrect kubectl attach commands in image volume documentation #53616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix incorrect kubectl attach commands in image volume documentation #53616
Conversation
|
Welcome @yanhuan0802! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yanhuan0802 Thanks for your contribution. It appears that this PR includes changes to files across multiple languages English and Chinese. However, docs follows different processes for each localization, and and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. After the merge of the English content, we could create separate pull request for the remaining language(s). I hope this suggestion is helpful.
|
Explicit hold until this PR only covers one language |
0e3bf5d to
a4c463b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
@dipesh-rawat Updated. PTAL |
|
/remove-language zh |
|
Is there a reason for switching from |
Description
This PR fixes incorrect
kubectl attachcommands in the image volume documentation.The original commands used
kubectl attach -it image-volume bash, which:bashargument (kubectl attach doesn't accept command arguments)sleep infinityAll instances have been replaced with
kubectl exec -it image-volume -- bash, which correctly:Files modified:
content/en/docs/tasks/configure-pod-container/image-volumes.md(2 occurrences)content/en/blog/_posts/2025-04-29-image-volume-beta/index.md(1 occurrence)Issue
#53623