Return default errors so they can be overridden by users#33
Closed
gerardsn wants to merge 1 commit intolabstack:mainfrom
Closed
Return default errors so they can be overridden by users#33gerardsn wants to merge 1 commit intolabstack:mainfrom
gerardsn wants to merge 1 commit intolabstack:mainfrom
Conversation
Author
|
@aldas this also restores functionality that was available in the previous middleware (overwriting the now ignored default errors) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the default errors
ErrJWTMissingandErrJWTInvalidare currently unused. I believe the currently returned error should should have been derived from the default errors so they can be overridden by users.For example, we prefer to let
ErrJWTMissingreturn a 401 but it is currently hardcoded to a 400. (which is also inconsistent with the default error, but I've changed the default error to match the existing behavior)