Thing client exceptions #236
Merged
+299
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianstirling
force-pushed
the
ThingClient-exceptions
branch
from
029e942 to
b33fe62
Compare
Barecheck - Code coverage reportTotal: 96.17%Your code coverage diff: 0.23% ▴ Uncovered files and lines
|
rwb27
approved these changes
Jan 6, 2026
Collaborator
rwb27
left a comment
rwb27
left a comment
There was a problem hiding this comment.
This is great. I've expanded a couple of docstrings in suggestions but otherwise please merge as-is :)
rwb27
force-pushed
the
ThingClient-exceptions
branch
from
7e100db to
ce9e9c1
Compare
Collaborator
|
Sorry for the force-push, I made suggestions for docstrings, but some lines were too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #235, adding somewhat better errors when a ThingClient throws an error when trying to invoke an action or get/set a property (#234).
It would be good eventually to check the thing descriptions and provide more useful errors for things like Read Only properties.