feat: Implement before_connect callback to modify connect options.#3562
Closed
jrasanen wants to merge 4 commits intolaunchbadge:mainfrom
Closed
feat: Implement before_connect callback to modify connect options.#3562jrasanen wants to merge 4 commits intolaunchbadge:mainfrom
jrasanen wants to merge 4 commits intolaunchbadge:mainfrom
Conversation
Author
|
AFAIK, this closes #3117 |
Author
|
I would not normally mention people in pull-requests, but @abonander reviewed and accepted the previous related PR regarding this. |
Allows the user to see and maybe modify the connect options before each attempt to connect to a database. May be used in a number of ways, e.g.: - adding jitter to connection lifetime - validating/setting a per-connection password - using a custom server discovery process
Allows the user to see and maybe modify the connect options before each attempt to connect to a database. May be used in a number of ways, e.g.: - adding jitter to connection lifetime - validating/setting a per-connection password - using a custom server discovery process
jrasanen
force-pushed
the
before_connect
branch
from
76b5c16 to
7b42bfc
Compare
abonander
approved these changes
Oct 15, 2024
Collaborator
|
I appreciate the effort, but I ended up deciding to go in a different direction. This has been superceded by #3582 and the |
|
@abonander Perhaps it makes sense to merge this small PR while you are working on the other one. Also the PR you are working on appears to be non-backward compatible, do you want to release it under a different major version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to see and maybe modify the connect options before each attempt to connect to a database. May be used in a number of ways, e.g.:
The original author of this PR stopped responding, so I cherry-picked the work done in this pull request and rebased this against the latest main.
Would be great to see this PR land into the main!
Thanks