Skip to content

Conversation

@ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Feb 17, 2025

There are some CI failures as follows:

  • Build LPython to WASM: it tries to use node 14 which is no longer available in the latest upstream emscripten. We fix this by instead installing node 18.
  • Uninitialize error: Fixed by initializing struct data members
  • micromamba unable to resolve dependencies: Fixed by pinning node version to 18.20.5 before the freeze-installed step.
  • Some flaky tests as shared in Some CI tests are flaky or real failures #2824.

@ubaidsk ubaidsk changed the title Use node 18 with emscripten Fix some CI failures Feb 17, 2025
@ubaidsk ubaidsk force-pushed the ubaid/pr/fix_ci_emscripten branch 2 times, most recently from bf5b5d3 to 22e98b3 Compare February 17, 2025 20:50
@ubaidsk ubaidsk changed the title Fix some CI failures Fix CI failures Feb 17, 2025
@ubaidsk ubaidsk force-pushed the ubaid/pr/fix_ci_emscripten branch 2 times, most recently from 2e9b6b1 to b53e5a3 Compare February 17, 2025 21:32
@ubaidsk ubaidsk force-pushed the ubaid/pr/fix_ci_emscripten branch from 3cc219b to f3b8773 Compare February 17, 2025 22:25
python run_tests.py --skip-run-with-dbg --no-color
else:
python run_tests.py
python run_tests.py --skip-run-with-dbg
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are currently 5 debug reference tests. These are for now skipped.

RUN(NAME test_types_01 LABELS cpython llvm llvm_jit c)
RUN(NAME test_types_02 LABELS cpython llvm llvm_jit c wasm)
RUN(NAME test_str_01 LABELS cpython llvm llvm_jit c)
# RUN(NAME test_str_01 LABELS cpython llvm llvm_jit c)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted here.

@ubaidsk ubaidsk marked this pull request as ready for review February 17, 2025 22:44
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Mar 12, 2025

Closing as the other PR #2825 was merged.

@ubaidsk ubaidsk closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant