-
Notifications
You must be signed in to change notification settings - Fork 0
Table component page #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table component page #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes #88 by updating the generic usage of the Table component across several component pages and tests, and by adding a footer to the Table component. Key changes include:
- Updating Table generic types from two parameters to one to simplify component usage.
- Injecting a table footer to render footer groups in the Table component.
- Adding lazy-loading for the new TableComponents route.
Reviewed Changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Components/components/*Components.tsx | Updated Table generic type usage and column definitions. |
| src/pages/Components/ComponentsPage.tsx | Added useEffect scroll-to-top and TableComponents route item. |
| src/common/components/Table/tests/Table.test.tsx | Updated Table rendering with new generic usage. |
| src/common/components/Table/stories/Table.stories.tsx | Updated Table component instantiation with new generic usage. |
| src/common/components/Table/Table.tsx | Modified TableProps interface and added Table footer rendering. |
| src/common/components/Router/Router.tsx | Registered lazy-loaded TableComponents route. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/common/components/Table/Table.tsx:29
- Ensure that removing the TValue generic parameter from the TableProps interface does not impact any dependent type checks or usage in the codebase.
const Table = <TData,>({
src/common/components/Table/Table.tsx:83
- Verify that 'flexRender' is properly imported to prevent runtime errors during table footer rendering.
flexRender(header.column.columnDef.footer, header.getContext())
📢 Instructions
🔧 Change Summary
Describe the changes included in this pull request. Link to the associated GitHub issue(s).
Tablecomponent.📝 Checklist
Pull request authors must complete the following tasks before marking the PR as ready to review.
🧪 Steps to Test
Describe the process to test the changes in this pull request.
🔗 Additional Information
Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.