Skip to content

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Mar 31, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. Go to the components page.
  2. Click on "Table" in the left-side navigation.
  3. Verify that the content and examples for the Table component are good.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Mar 31, 2025
@mwarman mwarman linked an issue Mar 31, 2025 that may be closed by this pull request
@mwarman mwarman requested a review from Copilot March 31, 2025 18:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes #88 by updating the generic usage of the Table component across several component pages and tests, and by adding a footer to the Table component. Key changes include:

  • Updating Table generic types from two parameters to one to simplify component usage.
  • Injecting a table footer to render footer groups in the Table component.
  • Adding lazy-loading for the new TableComponents route.

Reviewed Changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/pages/Components/components/*Components.tsx Updated Table generic type usage and column definitions.
src/pages/Components/ComponentsPage.tsx Added useEffect scroll-to-top and TableComponents route item.
src/common/components/Table/tests/Table.test.tsx Updated Table rendering with new generic usage.
src/common/components/Table/stories/Table.stories.tsx Updated Table component instantiation with new generic usage.
src/common/components/Table/Table.tsx Modified TableProps interface and added Table footer rendering.
src/common/components/Router/Router.tsx Registered lazy-loaded TableComponents route.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

src/common/components/Table/Table.tsx:29

  • Ensure that removing the TValue generic parameter from the TableProps interface does not impact any dependent type checks or usage in the codebase.
const Table = <TData,>({

src/common/components/Table/Table.tsx:83

  • Verify that 'flexRender' is properly imported to prevent runtime errors during table footer rendering.
flexRender(header.column.columnDef.footer, header.getContext())

@mwarman mwarman marked this pull request as ready for review April 1, 2025 10:31
@mwarman mwarman merged commit 21fc996 into main Apr 1, 2025
5 checks passed
@mwarman mwarman deleted the 88-table-component-page branch April 1, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table component page

2 participants