Skip to content

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Apr 2, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. Go to the components page.
  2. Click on the "Link" link in the left-side menu.
  3. Verify that the examples and content are good.
  4. Run a Google Lighthouse test and ensure there are no findings.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Apr 2, 2025
@mwarman mwarman linked an issue Apr 2, 2025 that may be closed by this pull request
@mwarman mwarman requested a review from Copilot April 2, 2025 11:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the accessibility of the Link component by updating its styling, adding a new example page, and ensuring proper routing and test coverage. Key changes include:

  • Adding a new LinkComponents example page and its corresponding tests.
  • Updating the routing and navigation to include the Link component.
  • Enhancing the styling of the Link component and its story.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/pages/Components/components/tests/LinkComponents.test.tsx Added unit test for LinkComponents rendering
src/pages/Components/components/LinkComponents.tsx Created a new example page showcasing various Link usages
src/pages/Components/ComponentsPage.tsx Updated menu to include navigation to the Link example page
src/common/components/Router/Router.tsx Added lazy import and route for LinkComponents
src/common/components/Link/stories/Link.stories.tsx Updated styling to reflect accessibility improvements
src/common/components/Link/Link.tsx Modified Link component styling for enhanced visual accessibility

@mwarman mwarman marked this pull request as ready for review April 2, 2025 11:49
@mwarman mwarman merged commit 071dc25 into main Apr 2, 2025
5 checks passed
@mwarman mwarman deleted the 116-accessibility---links-rely-on-color-to-be-distinguishable branch April 2, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility - Links rely on color to be distinguishable

2 participants