tree: allow for a tree limit in Tree::count_recursive#996
Open
carlosmn wants to merge 1 commit intolibgit2:masterfrom
Open
tree: allow for a tree limit in Tree::count_recursive#996carlosmn wants to merge 1 commit intolibgit2:masterfrom
Tree::count_recursive#996carlosmn wants to merge 1 commit intolibgit2:masterfrom
Conversation
Sometimes you find yourself with a repository that not only has a lot of blobs but a lot of trees without many blobs in between. Such a repository can cause `count_recursive` to take a long time to return. Allow for a second limit for the number of trees. If unset we use the limit for blobs which will not have any effect unless you have less than one blob per tree, which is roughly what we're trying to protect against here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you find yourself with a repository that not only has a lot of blobs but a lot of trees without many blobs in between. Such a repository can cause
count_recursiveto take a long time to return.Allow for a second limit for the number of trees. If unset we use the limit for blobs which will not have any effect unless you have less than one blob per tree, which is roughly what we're trying to protect against here.
This issue was pointed out by #995