-
Notifications
You must be signed in to change notification settings - Fork 180
feat: deploy secrets as secretRef in chart values #2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
merll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes as current implementation does not seem to work well when moving on to sealed secrets.
values/harbor/harbor.gotmpl
Outdated
|
|
||
| resources: {{- $h.resources.core | toYaml | nindent 4 }} | ||
| secret: {{ $h | get "core.secret" nil | quote }} | ||
| existingSecretKey: harbor-core-secret-key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core.existingSecretKey does not exist in the Harbor helm chart. Did you mean core.secretName?
We have not set it before because we are relying on istio mTLS. What is the reason you decided to se it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mixed some things together in my notes, should now be fixed.
j-zimnowoda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one inline comment.
While running bin/compare.sh script I noticed that few Loki secretRefs are set to null which does not seem to be right.
spec.template.spec.containers.compactor
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
data.config.yaml
± value change in multiline text (one insert, one deletion)
- s3: https://someaccessKeyId:somesecretvalue@nl-ams-1.linodeobjects.com/my-clusterid-loki
+ s3: https://${S3_ACCESS_KEY_ID}:${S3_ACCESS_KEY_SECRET}@nl-ams-1.linodeobjects.com/my-clusterid-loki
spec.template.spec.containers.distributor
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
spec.template.spec.containers.ingester
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
spec.template.spec.containers.querier
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
spec.template.spec.containers.query-frontend
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
📌 Summary
Replaces secrets withs secretRefs for Harbor and Oauth2-Proxy.
Uses environment Variables for Loki.