Skip to content

Release v1.136.1 - staging → master #11679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coliu-akamai merged 2 commits into from
Feb 19, 2025
Merged

Release v1.136.1 - staging → master #11679

coliu-akamai merged 2 commits into from
Feb 19, 2025

Conversation

@hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Feb 18, 2025 •
edited
Loading

Cloud Manager

Fixed:

  • Uptime not displaying in Longview (#11667)

Validation

Fixed:

  • Inability to add LKE Node Pool Labels with underscore in key (#11682)

@harsh-akamai @hkhalil-akamai
hotfix: Uptime interface for LongView API response (#11667)
0041cce 
* fixed uptime interface to match api response

* version bump

* Update changelog

---------

Co-authored-by: Hussain Khalil <hkhalil@akamai.com>
@hkhalil-akamai hkhalil-akamai added Release Cloud Manager releases Hotfix Hotfix: This is going to staging labels Feb 18, 2025
@hkhalil-akamai hkhalil-akamai self-assigned this Feb 18, 2025
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner February 18, 2025 19:36
abailly-akamai
abailly-akamai previously approved these changes Feb 18, 2025
View reviewed changes
coliu-akamai
coliu-akamai previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

mjac0bs
mjac0bs previously approved these changes Feb 18, 2025
View reviewed changes
jaalah-akamai
jaalah-akamai previously approved these changes Feb 18, 2025
View reviewed changes
cpathipa
cpathipa previously approved these changes Feb 18, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Coverage Report: ✅
Base Coverage: 79.25%
Current Coverage: 79.25%

jdamore-linode
jdamore-linode previously approved these changes Feb 18, 2025
View reviewed changes
@cypress
Copy link

cypress bot commented Feb 18, 2025 •
edited
Loading

Cloud Manager E2E    Run #7248

Run Properties:  status check passed Passed #7248  •  git commit 2be11708a4: Merge pull request #11679 from linode/staging
Project Cloud Manager E2E
Branch Review master
Run status status check passed Passed #7248
Run duration 34m 04s
Commit git commit 2be11708a4: Merge pull request #11679 from linode/staging
Committer Connie Liu
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 500
View all changes introduced in this branch ↗︎

@mjac0bs
fix: [M3-9343] - Fix validation with LKE Node Pool Labels creation (#…
f610cb9 
…11682)

* Add missing underscore to validation for key

* Update test coverage with more complex label/taint naming

* Update changelog

* Update changelog

* Re-add the change in 7e415e4 that vanished

* Bump validation package.json, correct changelog
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner February 18, 2025 23:33
mjac0bs
mjac0bs approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@linode-gh-bot
Copy link
Collaborator

linode-gh-bot commented Feb 19, 2025

Cloud Manager UI test results

🎉 500 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing500 Passing2 Skipped100m 47s

@coliu-akamai coliu-akamai merged commit 2be1170 into master Feb 19, 2025
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@cpathipa cpathipa cpathipa left review comments

@abailly-akamai abailly-akamai abailly-akamai left review comments

@hasyed-akamai hasyed-akamai Awaiting requested review from hasyed-akamai hasyed-akamai is a code owner automatically assigned from linode/cloud-manager-code-reviewers

@dmcintyr-akamai dmcintyr-akamai Awaiting requested review from dmcintyr-akamai dmcintyr-akamai is a code owner automatically assigned from linode/frontend-sdet

+2 more reviewers

@mjac0bs mjac0bs mjac0bs approved these changes

@jaalah-akamai jaalah-akamai jaalah-akamai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hkhalil-akamai hkhalil-akamai

Labels

Hotfix Hotfix: This is going to staging Release Cloud Manager releases

Projects

Cloud Manager
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@hkhalil-akamai @linode-gh-bot @jdamore-linode @mjac0bs @cpathipa @jaalah-akamai @abailly-akamai @coliu-akamai @harsh-akamai