Skip to content

Conversation

@jaalah-akamai
Copy link
Contributor

Fixed:

  • Unable to save non-US billing contact information without tax id (#11725)

jaalah and others added 4 commits February 25, 2025 13:05
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
fix: [M3-9410] - Unable to save non-US billing contact info without tax id
@jaalah-akamai
Copy link
Contributor Author

cc: @coliu-akamai Tags have been pushed already 👍

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed specifications from prev pr

thank you

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 25, 2025
@cypress
Copy link

cypress bot commented Feb 25, 2025

Cloud Manager E2E    Run #7293

Run Properties:  status check failed Failed #7293  •  git commit b5db23fa52: Merge pull request #11729 from linode/staging
Project Cloud Manager E2E
Branch Review master
Run status status check failed Failed #7293
Run duration 31m 24s
Commit git commit b5db23fa52: Merge pull request #11729 from linode/staging
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 520
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts • 1 failed test

View Output Video

Test Artifacts
Integration Tests for Edit Alert > should correctly display and update the details of the alert in the edit alert page Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  stackscripts/smoke-community-stackscripts.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Community Stackscripts integration tests > pagination works with infinite scrolling Screenshots Video
Flakiness  parentChild/account-switching.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page Screenshots Video
Flakiness  placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can delete without Linodes assigned when unexpected error show up and retry Screenshots Video

@github-actions
Copy link

Coverage Report:
Base Coverage: 79.98%
Current Coverage: 79.98%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing520 Passing3 Skipped110m 38s

Details

Failing Tests
SpecTest
edit-system-alert.spec.tsIntegration Tests for Edit Alert » should correctly display and update the details of the alert in the edit alert page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts"

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can disregard the test failure here: it's been fixed in develop.

Just to clarify: I was under the impression this field is required for companies -- have we confirmed that this should be optional for all customers vs being optional only for individuals?

@jaalah-akamai
Copy link
Contributor Author

jaalah-akamai commented Feb 25, 2025

@jdamore-linode The PM seemed pretty clear in my discussion that this is an optional field - Validation still occurs if there's a Tax Id and the agreement checkbox is still required to check, so I think we're safe here. I think leaving this as is until tomorrow will generate more support tickets

@coliu-akamai
Copy link
Contributor

merging into master as per discussions!

@coliu-akamai coliu-akamai merged commit b5db23f into master Feb 25, 2025
43 of 45 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 25, 2025
@mjac0bs mjac0bs added the Hotfix Hotfix: This is going to staging label Feb 27, 2025
venkymano-akamai pushed a commit to agorthi-akamai/manager that referenced this pull request Mar 5, 2025
Release v1.137.1 - staging → master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hotfix Hotfix: This is going to staging Release Cloud Manager releases

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants