-
Notifications
You must be signed in to change notification settings - Fork 392
Release v1.137.1 - staging → master #11729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
fix: [M3-9410] - Unable to save non-US billing contact info without tax id
|
cc: @coliu-akamai Tags have been pushed already 👍 |
coliu-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed specifications from prev pr
thank you
|
Coverage Report: ✅ |
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts" |
|||||||||||||||||
jdamore-linode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can disregard the test failure here: it's been fixed in develop.
Just to clarify: I was under the impression this field is required for companies -- have we confirmed that this should be optional for all customers vs being optional only for individuals?
|
@jdamore-linode The PM seemed pretty clear in my discussion that this is an optional field - Validation still occurs if there's a Tax Id and the agreement checkbox is still required to check, so I think we're safe here. I think leaving this as is until tomorrow will generate more support tickets |
|
merging into master as per discussions! |
Release v1.137.1 - staging → master
Fixed: