new: [STORIF-187] - Global quota usage table created. #13197
+299
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
3 times, most recently
from
e492df1 to
1c7f2aa
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
3 times, most recently
from
6c6c081 to
154edf3
Compare
dchyrva-akamai
requested review from
cliu-akamai
and removed request for
a team
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
2 times, most recently
from
6d4cd7e to
dbcea0e
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
4 times, most recently
from
67ab331 to
ff1f699
Compare
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
from
ff1f699 to
4d7ce9a
Compare
| globalQuota: GlobalQuotaWithUsage; | ||
| } | ||
|
|
||
| const quotaRowMinHeight = 58; |
Contributor
There was a problem hiding this comment.
move this to a constant file as QUOTA_ROW_MIN_HEIGHT since reused in multiple components
| setMethod('GET'), | ||
| setXFilter(filter), | ||
| setParams(params), | ||
| ); |
Contributor
There was a problem hiding this comment.
Do you need a "get all" method as well? Could we have more than 500 records?
| const globalQuotaIds = | ||
| globalQuotas?.data.map((quota) => quota.quota_id) ?? []; | ||
| const globalQuotaUsageQueries = useQueries({ | ||
| queries: globalQuotaIds.map((quotaId) => |
Contributor
There was a problem hiding this comment.
How many quota IDs could you end up having to fetch in parallel? Asking because this could end up being a bad performance bottleneck if running queries for dozens (hundreds) of IDs.
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #13 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
|||||||||||||||||
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
from
4d7ce9a to
b318454
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
from
b318454 to
4c4c9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Global quota usage table created.
Changes 🔄
useGetObjGlobalQuotasWithUsagehook.GlobalQuotasTablecomponent.Preview 📷
How to test 🧪
docker-compose up -d apinext..envfile of the Cloud Manager to use local API instance.pnpm dev/quotaspage.Related PRs
apinext
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅