upcoming: [DI-28750] - Add edit feature for notification channels #13235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkymano-akamai
approved these changes
Jan 1, 2026
santoshp210-akamai
approved these changes
Jan 5, 2026
bnussman-akamai
approved these changes
Jan 5, 2026
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Just left a few minor suggestions
| return ( | ||
| <> | ||
| <Breadcrumb crumbOverrides={overrides} pathname={pathname} /> | ||
| <Box alignContent="center" height="600px"> |
Member
There was a problem hiding this comment.
This might be okay but maybe a minHeight would serve us better and save us from potentional overflow issues in the longer run
| * @param crumbOverrides - The overrides to be provided in breadcrumb | ||
| * @param children - The message component (e.g., CircleProgress, ErrorState, or Placeholder) | ||
| */ | ||
| const EditChannelState = ({ |
Member
There was a problem hiding this comment.
A better name may be something like EditChannelContainer
|
|
||
| const cloudPulseNotificationChannelEditRoute = createRoute({ | ||
| getParentRoute: () => cloudPulseAlertsRoute, | ||
| path: 'notification-channels/edit/$channelId', |
Member
There was a problem hiding this comment.
Params should be parsed here. That will make it so that we don't need to cast the string to a number everywhere in the app
Suggested change
| path: 'notification-channels/edit/$channelId', | |
| path: 'notification-channels/edit/$channelId', | |
| params: { | |
| parse: (rawParams) => ({ | |
| channelId: Number(rawParams.channelId), | |
| }), | |
| }, |
Comment on lines
338
to
342
| export const useNotificationChannelQuery = (channelId: number) => { | ||
| return useQuery<NotificationChannel, APIError[]>({ | ||
| ...queryFactory.notificationChannels._ctx.channelById(channelId), | ||
| }); | ||
| }; |
Member
There was a problem hiding this comment.
nit: We could remove the spread operation here
Suggested change
| export const useNotificationChannelQuery = (channelId: number) => { | |
| return useQuery<NotificationChannel, APIError[]>({ | |
| ...queryFactory.notificationChannels._ctx.channelById(channelId), | |
| }); | |
| }; | |
| export const useNotificationChannelQuery = (channelId: number) => { | |
| return useQuery<NotificationChannel, APIError[]>( | |
| queryFactory.notificationChannels._ctx.channelById(channelId) | |
| ); | |
| }; |
| if (!channelData) { | ||
| return <StyledPlaceholder icon={EntityIcon} title="No Data to display." />; | ||
| } | ||
| return <NullComponent />; |
Member
There was a problem hiding this comment.
nit: we could just use null
Suggested change
| return <NullComponent />; | |
| return null; |
…anager into feature/edit_channel_aclp
…e/edit_channel_aclp
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
|||||||||||||||||
Contributor
Author
|
Merging as there are enough approvals and failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add edit feature for notification channels.
Changes 🔄
/alerts/notification-channels/edit/$channelIdwith lazy loadingfilterEditChannelFormValuesutility to transform form data to API payload formatScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
13 jan 2026
Preview 📷
How to test 🧪
Verification steps
[Verify in mock env]
Type,Name, andRecipients.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅