Rename all shell scripts to *.sh + shellcheck -x success#2050
Rename all shell scripts to *.sh + shellcheck -x success#2050tlaurion wants to merge 1 commit intolinuxboot:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames shell scripts to include .sh extensions and adds shellcheck compliance improvements. It updates script references across config files and adds shellcheck directives to scripts.
Changes:
- Renamed shell scripts by adding
.shextension - Updated CONFIG_BOOTSCRIPT paths in board configuration files
- Added shellcheck source directives and disabled warnings where appropriate
- Improved shell script compliance with shellcheck recommendations
Reviewed changes
Copilot reviewed 105 out of 158 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| Config files (boards/*) | Updated CONFIG_BOOTSCRIPT paths to use .sh extensions |
| Shell scripts (initrd/bin/*) | Renamed scripts, added shellcheck directives, improved compliance |
| Config files (unmaintained_boards/*) | Updated CONFIG_BOOTSCRIPT paths, some with inconsistent leading slash |
| initrd/init | Updated script calls and added shellcheck compliance fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CONFIG_LINUX_BCM=y | ||
|
|
||
| export CONFIG_BOOTSCRIPT=/bin/generic-init | ||
| export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.
|
|
||
| export CONFIG_TPM=n | ||
| export CONFIG_BOOTSCRIPT=/bin/generic-init | ||
| export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.
| CONFIG_LINUX_E1000E=y | ||
|
|
||
| export CONFIG_BOOTSCRIPT=/bin/generic-init | ||
| export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.
| export CONFIG_QUIET_MODE=y | ||
| export CONFIG_BOOTSCRIPT=/bin/gui-init | ||
| #export CONFIG_BOOTSCRIPT_NETWORK=/bin/network-init-recovery | ||
| #export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT commented line. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" for consistency.
| #export CONFIG_BOOTSCRIPT=/bin/generic-init | ||
| export CONFIG_BOOTSCRIPT=/bin/gui-init | ||
| #export CONFIG_BOOTSCRIPT_NETWORK=/bin/network-init-recovery | ||
| #export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT commented line. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" for consistency.
| CONFIG_LINUX_NVME=y | ||
|
|
||
| export CONFIG_BOOTSCRIPT=/bin/generic-init | ||
| export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.
| #CONFIG_LINUX_NVME=y | ||
|
|
||
| export CONFIG_BOOTSCRIPT=/bin/generic-init | ||
| export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.
| export CONFIG_QUIET_MODE=y | ||
| export CONFIG_BOOTSCRIPT=/bin/gui-init | ||
| #export CONFIG_BOOTSCRIPT_NETWORK=/bin/network-init-recovery | ||
| #export CONFIG_BOOTSCRIPT="bin/generic-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT commented line. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" for consistency with the pattern used in other config files.
| #Enable quiet mode: technical information logged under /tmp/debug.log | ||
| export CONFIG_QUIET_MODE=y | ||
| export CONFIG_BOOTSCRIPT=/bin/gui-init | ||
| export CONFIG_BOOTSCRIPT="bin/gui-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/gui-init.sh" but should be "/bin/gui-init.sh" to match the pattern used in other config files.
| export CONFIG_BOOTSCRIPT="bin/gui-init.sh" | |
| export CONFIG_BOOTSCRIPT="/bin/gui-init.sh" |
| #Enable quiet mode: technical information logged under /tmp/debug.log | ||
| export CONFIG_QUIET_MODE=y | ||
| export CONFIG_BOOTSCRIPT=/bin/gui-init | ||
| export CONFIG_BOOTSCRIPT="bin/gui-init.sh" |
There was a problem hiding this comment.
Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/gui-init.sh" but should be "/bin/gui-init.sh" to match the pattern used in other config files.
| export CONFIG_BOOTSCRIPT="bin/gui-init.sh" | |
| export CONFIG_BOOTSCRIPT="/bin/gui-init.sh" |
tlaurion
force-pushed
the
shellcheck_fixes
branch
from
b089a7b to
cdfe716
Compare
…s for consistency vs origin/master + shellcheck fixes/silencing Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
force-pushed
the
shellcheck_fixes
branch
from
cdfe716 to
b1aaf47
Compare
|
Unfortunately something broke with tpm sealing unsealing totp and not ready for full test/review. |
1 participant
No description provided.