add support for rockchip h264/h265 video encoders#885
Draft
chenosaurus wants to merge 3 commits intomainfrom
Draft
add support for rockchip h264/h265 video encoders#885chenosaurus wants to merge 3 commits intomainfrom
chenosaurus wants to merge 3 commits intomainfrom
Conversation
ladvoc
approved these changes
Feb 20, 2026
Contributor
ladvoc
left a comment
ladvoc
left a comment
There was a problem hiding this comment.
LGTM ✅, this should be tested on-device if it hasn't been already before merging.
| let mut sum_iter_ms = 0.0; | ||
| let mut logged_mjpeg_fallback = false; | ||
| let mut consecutive_capture_errors: u32 = 0; | ||
| const MAX_CONSECUTIVE_CAPTURE_ERRORS: u32 = 30; |
Contributor
There was a problem hiding this comment.
question: What leads to these intermittent capture errors? Is 30 the right limit to set?
| ); | ||
| } | ||
|
|
||
| if arm { |
Contributor
There was a problem hiding this comment.
comment (non-blocking): I'm wondering if we should put all hardware encoders behind crate features. Ideally, we shouldn't be compiling hardware-specific code on platforms that can't take advantage of it. @cloudwebrtc, did you consider this when adding support for NVIDIA?
Contributor
|
One more thing: the README should be to list Rockchip under the "Hardware video enc/dec" section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.