[Kaleidoscope] Update tutorial ch4 to match example code document #172395
Conversation
The line assert(ExprSymbol && "Function not found"); has been removed as it does not compile and is not present in the code document. References to the assert in the tutorial have also been removed. double (*FP)() = ExprSymbol.getAddress().toPtr<double (*)()>(); has been changed to double (*FP)() = ExprSymbol.toPtr<double (*)()>(); to match the code document's use of newer API. Reference to the getAdress() function has also been removed.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
3 participants
The assert line has been removed as it does not compile and is not present in the code document. References to the assert in the tutorial have also been removed.
ExprSymbol.getAddress().toPtr<double ()()>(); has been changed to
ExprSymbol.toPtr<double ()()>(); to match the code document's use of newer API. Reference to the getAdress() function has also been removed.