Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

Just to keep things up to date. It does not look like we can yet jump to VS 2026 despite it being available since the vs_buildtools.exe link does not work with VS v18 (which corresponds to Visual Studio 2026).

I've tested this locally running the full premerge pipeline and everything checks out.

Just to keep things up to date. It does not look like we can yet jump to
VS 2026 despite it being available since the vs_buildtools.exe link does
not work with VS v18 (which corresponds to Visual Studio 2026).
@llvmbot
Copy link
Member

llvmbot commented Dec 16, 2025

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

Just to keep things up to date. It does not look like we can yet jump to VS 2026 despite it being available since the vs_buildtools.exe link does not work with VS v18 (which corresponds to Visual Studio 2026).

I've tested this locally running the full premerge pipeline and everything checks out.


Full diff: https://github.com/llvm/llvm-project/pull/172396.diff

1 Files Affected:

  • (modified) .github/workflows/containers/github-action-ci-windows/Dockerfile (+5-5)
diff --git a/.github/workflows/containers/github-action-ci-windows/Dockerfile b/.github/workflows/containers/github-action-ci-windows/Dockerfile
index 15ac8d38af0b5..ec242e6b7da6c 100644
--- a/.github/workflows/containers/github-action-ci-windows/Dockerfile
+++ b/.github/workflows/containers/github-action-ci-windows/Dockerfile
@@ -6,21 +6,21 @@ FROM mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2022
 SHELL ["cmd", "/S", "/C"]
 
 # Download the Build Tools bootstrapper.
-ADD https://aka.ms/vs/16/release/vs_buildtools.exe /TEMP/vs_buildtools.exe
+ADD https://aka.ms/vs/17/release/vs_buildtools.exe /TEMP/vs_buildtools.exe
 
 RUN powershell -Command Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
 
 # Download channel for fixed install.
-ARG CHANNEL_URL=https://aka.ms/vs/16/release/channel
+ARG CHANNEL_URL=https://aka.ms/vs/17/release/channel
 ADD ${CHANNEL_URL} /TEMP/VisualStudio.chman
 
 # Install Build Tools with C++ workload.
 #   - Documentation for docker installation
-#     https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container?view=vs-2019
+#     https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container
 #   - Documentation on workloads
-#     https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2019#c-build-tools
+#     https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools
 #   - Documentation on flags
-#     https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio?view=vs-2019
+#     https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio
 RUN /TEMP/vs_buildtools.exe --quiet --wait --norestart --nocache \
     --channelUri C:\TEMP\VisualStudio.chman \
     --installChannelUri C:\TEMP\VisualStudio.chman \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants