Open
Conversation
banadiga
requested review from
a user,
alex-muliarevych,
flylight,
iverhun,
kristi-hospodarysko,
rakatosh and
tsypuk
iverhun
requested changes
Jul 17, 2017
| ADD api-gateway-service.jar api-gateway-service.jar | ||
| ADD wrapper.sh wrapper.sh | ||
| RUN bash -c 'chmod +x /wrapper.sh' | ||
| RUN bash -c 'touch /app.jar' |
| links: | ||
| - discovery-server | ||
| environment: | ||
| - WATE=true |
| private static final String STORAGE_SERVICE = "storage-service_1"; | ||
| private static final int STORAGE_SERVICE_PORT = 8091; | ||
|
|
||
| private static final String compose = EntToEndIntegrationTest.class.getClassLoader() |
banadiga
changed the title
banadiga
force-pushed
the
integration-tests
branch
from
21f0d8d to
ddb6e3f
Compare
banadiga
force-pushed
the
integration-tests
branch
from
b97822e to
42f5e2c
Compare
banadiga
force-pushed
the
integration-tests
branch
from
42f5e2c to
839f377
Compare
…fig.uri from wrapper.sh
banadiga
force-pushed
the
integration-tests
branch
from
dcb20a3 to
b9f92fb
Compare
flylight
reviewed
Jan 3, 2018
Collaborator
flylight
left a comment
flylight
left a comment
There was a problem hiding this comment.
Please, take a look on my comments.
|
|
||
| if [ "$WAITING_FOR_DEPENDENCE" != "true" ]; then | ||
| echo "Starting config server immediately" | ||
| java -jar ./client-service.jar |
Collaborator
There was a problem hiding this comment.
Is this file is autogenerated ? If yes then do we need it to be pushed ? If no then should we always maintain it and support configuration ?
| Thread.sleep(SLEEP); | ||
| try { | ||
| httpResponse = client.execute(httpGet); | ||
| } catch (IOException ignored) { |
Collaborator
There was a problem hiding this comment.
Maybe throw it away instead of ignoring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-testDockerfile/infoendpoint