test #44

Kvarkas · 2025-09-01T08:58:13Z

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Changed feature (non-breaking change which changes functionality)
Changed feature (breaking change which changes functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Updated translation

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
All Tests within VisualStudio are passing
This pull request does not target the master branch.
I have updated the changelog file accordingly, if necessary.
I have updated the documentation accordingly, if necessary.

…thub.io into svelteKit

Шрифт и иконка

Ссылки в главное меню и выпадающий список

…thub.io into svelteKit

Added tooltips and titles ( пока что без мультиязычности, но при наведении на иконки и в выпадающем списке при наведении всё видно)

Bumps the npm_and_yarn group with 1 update in the / directory: [vite-plugin-static-copy](https://github.com/sapphi-red/vite-plugin-static-copy). Updates `vite-plugin-static-copy` from 3.1.0 to 3.1.2 - [Release notes](https://github.com/sapphi-red/vite-plugin-static-copy/releases) - [Changelog](https://github.com/sapphi-red/vite-plugin-static-copy/blob/main/CHANGELOG.md) - [Commits](https://github.com/sapphi-red/vite-plugin-static-copy/compare/vite-plugin-static-copy@3.1.0...vite-plugin-static-copy@3.1.2) --- updated-dependencies: - dependency-name: vite-plugin-static-copy dependency-version: 3.1.2 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>

…_yarn-d42c96e7b6 Bump vite-plugin-static-copy from 3.1.0 to 3.1.2 in the npm_and_yarn group across 1 directory

Copilot

Pull Request Overview

This PR introduces a complete migration from Jekyll to SvelteKit for the mRemoteNG website, creating a modern web application with internationalization (i18n), theme switching, and responsive design. The changes transform the static Jekyll site into a dynamic SvelteKit application with enhanced user experience features.

Key changes:

Complete SvelteKit application setup with TypeScript support and static adapter
Implementation of i18n support for multiple languages (English, Russian, German)
Addition of theme switching functionality with dark/light mode support
Bootstrap-based responsive UI with modern component structure

Reviewed Changes

Copilot reviewed 67 out of 116 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
package.json	SvelteKit project configuration with dependencies for UI framework and build tools
vite.config.ts	Vite configuration with TailwindCSS and SvelteKit plugins
svelte.config.js	SvelteKit configuration for static site generation and GitHub Pages deployment
src/routes/+layout.svelte	Main layout component with header, footer, and global styles
src/lib/components/*.svelte	Reusable UI components for header, footer, theme switcher, and language switcher
src/lib/i18n/*.ts/.json	Internationalization implementation with translation files
src/lib/stores/theme.js	Theme management store for dark/light mode switching
static/*	Static assets including CSS, JavaScript, icons, and favicon files

Comments suppressed due to low confidence (1)

static/js/theme-loader.js:1

Dead code should be removed instead of being commented out. This commented block serves no purpose and clutters the codebase.

(function() {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-01T08:59:26Z

vite.config.ts

+	plugins: [tailwindcss(), sveltekit()]
+


There is trailing whitespace on line 7. Remove the extra space to maintain consistent code formatting.

Suggested change

plugins: [tailwindcss(), sveltekit()]

Copilot · 2025-09-01T08:59:26Z

src/lib/stores/theme.js

@@ -0,0 +1,32 @@
+import { writable } from 'svelte/store';
+
+// Функция для безопасного доступа к localStorage


Comments are written in Russian but should be in English for consistency with the rest of the codebase and to ensure all team members can understand the code.

Copilot · 2025-09-01T08:59:26Z

src/lib/stores/theme.js

+    });
+}
+
+// Инициализация только на клиенте


Comments are written in Russian but should be in English for consistency with the rest of the codebase and to ensure all team members can understand the code.

Suggested change

// Инициализация только на клиенте

// Initialization only on the client

Copilot · 2025-09-01T08:59:27Z

src/lib/components/Header.svelte

+					<!-- Right side of the navbar -->
+					<ul class="navbar-nav ms-md-auto">
+						<li class="nav-item">
+							<a rel="noopener" class="nav-link" href="{base}/downloads"  title= "Donwloads">


There's a typo in the title attribute: 'Donwloads' should be 'Downloads'.

Suggested change

<a rel="noopener" class="nav-link" href="{base}/downloads" title= "Donwloads">

<a rel="noopener" class="nav-link" href="{base}/downloads" title="Downloads">

Copilot · 2025-09-01T08:59:27Z

src/app.css

+  font-family: 'HandelGotDBol', sans-serif;
+  background: #f0f0f0;
+  font-family: 'Open Sans', sans-serif;


The font-family property is declared twice on consecutive lines with different values. The second declaration will override the first, making line 14 ineffective.

Suggested change

font-family: 'HandelGotDBol', sans-serif;

background: #f0f0f0;

font-family: 'Open Sans', sans-serif;

font-family: 'Open Sans', sans-serif;

background: #f0f0f0;

Kvarkas and others added 30 commits July 28, 2023 11:55

refactoring cleanup

bb12d5d

гзвфеу

71af288

refactoring

e42430b

test

7b32596

add css

e941688

lib update

6e7a310

fix/patch for vulnerabilities

251315c

Всё было гораздо проще

768b6d9

Merge branch 'svelteKit' of https://github.com/ValeraBro/mRemoteNG.gi…

588aee2

…thub.io into svelteKit

свич с анимацией, меняет, но пока что только бэк

f854c55

Merge pull request #37 from ValeraBro/svelteKit

fbe8cb3

Шрифт и иконка

task 2

28709d6

Ссылки в главное меню и выпадающий список социал

2d377a1

Merge branch 'mRemoteNG:svelteKit' into svelteKit

04b912d

Merge pull request #38 from ValeraBro/svelteKit

0062726

Ссылки в главное меню и выпадающий список

теперь при наведении на ико появляется текст (пока что БЕЗ мульти ЯЗ)

2345104

Merge branch 'svelteKit' of https://github.com/ValeraBro/mRemoteNG.gi…

bb49bd3

…thub.io into svelteKit

Merge branch 'mRemoteNG:svelteKit' into svelteKit

967a978

Merge pull request #39 from ValeraBro/svelteKit

40d34f7

Added tooltips and titles ( пока что без мультиязычности, но при наведении на иконки и в выпадающем списке при наведении всё видно)

Alfa deploy

bab0221

changes for github pages

29ddc47

adding github action

9be730e

github actions enable

f1b8067

upgrade version

bafb84a

fixes

d332680

try

4ecc229

up version

1a9ebcf

test

2e78d4d

downgrade upload version

8e641be

upgrade

a9b9ea6

Kvarkas and others added 27 commits July 2, 2025 23:49

fix links about

f11e4d5

make image responsive

8c11921

fix image size

adf868f

redirect domain

400f2a1

fix image size

ae17ef8

fix for size

3744373

upd description

2466951

set headers

ec0fae6

Implementing Subresource Integrity

32c3f9d

integrity and style fix

85157ed

fixes

60986dc

remove styles

ec31977

fix for local font

96c9824

fix base

8a72c6b

fix local image

bf3383d

move script to file

aa88be7

disable inline styles

e138240

upd

273f91a

make it local

2096ba8

upd local

32c2e52

get back styles

678b67d

fixes

c9e8fb8

fix

99f2a08

fix for old app (update checks)

1786256

fix for name

a259ffc

Merge pull request #41 from mRemoteNG/dependabot/npm_and_yarn/npm_and…

c1aea83

…_yarn-d42c96e7b6 Bump vite-plugin-static-copy from 3.1.0 to 3.1.2 in the npm_and_yarn group across 1 directory

Kvarkas requested a review from Copilot September 1, 2025 08:58

Copilot AI reviewed Sep 1, 2025

View reviewed changes

Kvarkas closed this Sep 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test #44

test #44

Uh oh!

Kvarkas commented Sep 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,32 @@
		import { writable } from 'svelte/store';

		// Функция для безопасного доступа к localStorage

	// Инициализация только на клиенте
	// Initialization only on the client

	<a rel="noopener" class="nav-link" href="{base}/downloads" title= "Donwloads">
	<a rel="noopener" class="nav-link" href="{base}/downloads" title="Downloads">

test #44

test #44

Uh oh!

Conversation

Kvarkas commented Sep 1, 2025

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants