Fix/39286 product gallery image order #40366
Open
+179
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple images are selected for upload, maintain the original selection order instead of displaying them in the random order they complete uploading. Problem: - Migration from jquery/fileUpload to Uppy in 2.4.7 introduced async file uploads without preserving selection order - Images appear in gallery in the order uploads complete, not selection order - Affects user experience when uploading multiple product images Solution: - Track file selection order during onBeforeFileAdded callback - Buffer upload results and add them to gallery in correct order - Handle partial failures gracefully while maintaining order - Reset tracking variables between upload batches Changes: - Added filePositions tracking object to map file IDs to selection order - Added uploadedFiles buffer to store results temporarily - Modified upload-success handler to wait for all uploads before adding - Added upload-error handler for proper error handling - Enhanced complete handler for edge case cleanup Tests: - Verified JavaScript syntax is valid - Handles single and multiple file uploads - Maintains order even with async upload completion - Gracefully handles upload errors and partial failures Fixes: magento#39286
Added JavaScript tests to verify: - File selection order is preserved during async uploads - Partial upload failures are handled correctly while maintaining order - Upload completion logic works with different file completion orders Tests cover the core functionality of the magento#39286 fix.
|
Hi @satishashilwar. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When uploading multiple images to the product gallery in Magento 2.4.7+, images appear in random order instead of maintaining the user's selection order. This regression was introduced during the migration from jquery/fileUpload to Uppy for handling file uploads.
Root Cause
The migration to Uppy changed file upload behavior from sequential to asynchronous processing. While this improved performance, it broke order preservation because the upload-success handler added images to the gallery immediately upon completion, regardless of their original selection order.
Solution
Enhanced the base image uploader to track file selection order and buffer upload results:
Contribution checklist (*)