Skip to content

Conversation

@LookerClocker
Copy link
Collaborator

@LookerClocker LookerClocker commented Dec 8, 2025

Summary

Fixed paddingScale warning message in dev console. By make it transient props

Type of Change

  • πŸ› Bug fix
  • ✨ New feature
  • πŸ”§ Component enhancement
  • πŸ“š Documentation update
  • 🎨 Style/UI changes
  • βš™οΈ Misc

Component(s) Affected

  • Modified component: Tooltip

Changes Made

Replaced paddingScale with $paddingScale to avoid adding it into DOM direclty

Testing

  • Unit tests added/updated
  • Storybook stories added/updated
  • Manual testing completed
  • Accessibility testing performed
  • Cross-browser testing (if applicable)
  • Responsive design testing (if applicable)

Storybook

  • New stories created for new components
  • Existing stories updated to reflect changes
  • All component variants documented
  • Props table is accurate and complete
  • Examples demonstrate proper usage

Breaking Changes

Yes. We need to update all usages of Tooltip component

Screenshots/Videos

TODO

  • Update all usages of Tooltip component when downloading new cspr.design library version

Checklist

  • Code is properly formatted (Prettier/ESLint)
  • All commits are signed
  • TypeScript types are properly defined
  • Components follow design system guidelines
  • Accessibility requirements met (WCAG compliance)
  • Bundle size impact considered
  • Tests included/updated or not needed
  • Storybook stories included/updated or not needed
  • Documentation updated or not required
  • No console errors or warnings
  • Backward compatibility maintained (or breaking changes documented)

@LookerClocker LookerClocker self-assigned this Dec 8, 2025
@LookerClocker LookerClocker added the enhancement New feature or request label Dec 8, 2025
@LookerClocker LookerClocker changed the title fixed paddingScale warning Product Menu aligning. + fixed paddingScale warning Dec 12, 2025
Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test changing the flex property on CSPR.live and the items disalign
https://github.com/user-attachments/assets/c5274ae3-206c-4f57-962c-47674804fef3

Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugenebelov eugenebelov merged commit 85ef440 into master Dec 15, 2025
5 checks passed
@eugenebelov eugenebelov deleted the CLICK-840 branch December 15, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants