Consider tilesize when calculating the grid#45
Open
WMDE-Fisch wants to merge 1 commit intomapbox:masterfrom
Open
Consider tilesize when calculating the grid#45WMDE-Fisch wants to merge 1 commit intomapbox:masterfrom
WMDE-Fisch wants to merge 1 commit intomapbox:masterfrom
Conversation
This never worked before. The calculation for sizes other than 1 did use the right center point for the static image. The patch fixes that and also adjusts the test for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This never worked before. The calculation for sizes other than 1 did use the right center point for the static image.
The patch fixes that and also adjusts the test for it.
The code is currently used in a different fork that's deployed on the servers used here:
https://maps.wikimedia.org/img/osm-intl,18,43.748,7.434,400x400.png
https://maps.wikimedia.org/img/osm-intl,18,43.748,7.434,400x400@2x.png
@2xzooms the stitched tiles.There's also an older pull request that's a bit outdated now. #39