Skip to content

Conversation

@caglarpir
Copy link
Contributor

Summary:
In timelapse videos video time and gps track time have different scales.
Use the gps track timescale when calculating average speed of the gps track.

@caglarpir caglarpir requested a review from ptpt January 14, 2026 15:39
@meta-cla meta-cla bot added the cla signed label Jan 14, 2026
@caglarpir caglarpir force-pushed the gps-timestamp-speed branch 3 times, most recently from 12bebaf to de3098b Compare January 15, 2026 09:32
Copy link
Member

@ptpt ptpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the dependencies on telemetry as a follow up PR? Because geo.py is used in multiple places and it'd be better to stay generic. One idea could be moving specific implementations of avg_speed and _interpolate_segment to each Point class

Summary:
In timelapse videos video time and gps track time have different scales.
Use the gps track timescale when calculating average speed of the gps track.
@caglarpir caglarpir force-pushed the gps-timestamp-speed branch from de3098b to 3e9b157 Compare January 16, 2026 09:06
@caglarpir
Copy link
Contributor Author

Can you remove the dependencies on telemetry as a follow up PR? Because geo.py is used in multiple places and it'd be better to stay generic. One idea could be moving specific implementations of avg_speed and _interpolate_segment to each Point class

Very good point. I'll make it in this pull request.

@caglarpir caglarpir merged commit f867e6c into main Jan 16, 2026
16 checks passed
@caglarpir caglarpir deleted the gps-timestamp-speed branch January 16, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants