Ignore latidue and longitide in system test #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
snake14
reviewed
Mar 26, 2025
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With matomo-org/matomo#23155 we will change how latitude and longitude values are rounded.
This has an effect on one of the tests of this plugin.
However, as those values are not relevant for this plugin at all, I've decided to simply ignore them in test results, so we don't have any problems with getting the tests passing with older Matomo versions.