Avoid division by 0 in stalker under weird timer behaviour #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
approved these changes
Dec 4, 2025
Member
There was a problem hiding this comment.
Mention in the log message that such a behaviour might be caused by long running NIFs executed on normal schedulers.
Let's also bump patch in version and release it.
BTW IMO this will fix this error in YOLO demo: membraneframework/membrane_camera_capture_plugin#25
Member
Author
|
@FelonEkonom before we merge, please try running the demo with the fix a few times |
Member
|
I have run it and timeout on opening the camera doesn't cause any logs about Stalker crash. |
mat-hek
changed the title
mat-hek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.