Feature OQL show result count #20
Conversation
|
@Andries-Smit Is the MR now in a reviewable state? If otherwise, please mark it as draft. |
|
@pijuskri it is updated, and retested |
| /nativemobile/builds/ | ||
| /vendorlib/temp/ | ||
| .DS_Store | ||
| /.svn/ |
There was a problem hiding this comment.
I am not sure if this exclusion is necessary. We use git exclusively.
| /modeler-merge-marker | ||
| /nativemobile/builds/ | ||
| /vendorlib/temp/ | ||
| .DS_Store |
There was a problem hiding this comment.
This is OS specific so would rather propose for this to be included individually under .git/info/exclude
| } | ||
|
|
||
| @java.lang.Override | ||
| public java.lang.Long executeAction() throws Exception |
There was a problem hiding this comment.
We aim to test all new additions to the module, so please add some simple tests for this method/action. A few different InputString values with different number of lines, being empty or being null should be sufficient.
There was a problem hiding this comment.
In ACT_ExecuteOQL the decision now named "OQL?" should have a more clear name like "Is OQL text empty?"
There was a problem hiding this comment.
Similarly the validation message would be better if it was straight forward and say something like "Provided OQL query is empty"
There was a problem hiding this comment.
In OQL snippet the container container2 has styling class oql-results, but that class is not defined in any scss file.
There was a problem hiding this comment.
I am not sure if making the OQL input Text area be auto-growing is better than the current situation. In the master version the text box starts off with pre-determined size, but a user can still expand by dragging down. With auto grow, large OQL queries could take up quite some space and cause overflow on the parent page.
2 participants
Uh oh!
There was an error while loading. Please reload this page.