dirDisqus: prevent error when config object is undefined#347
Open
niklanus wants to merge 1 commit intomichaelbromley:masterfrom
Open
dirDisqus: prevent error when config object is undefined#347niklanus wants to merge 1 commit intomichaelbromley:masterfrom
niklanus wants to merge 1 commit intomichaelbromley:masterfrom
Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this error
TypeError: Cannot read property 'disqus_shortname' of undefinedwhen using a config object that got their data asynchronously, in my WP REST API + AngularJS front-end blog.Template:
<dir-disqus config="disqusConfig"></dir-disqus>Controller:
This is just a simple flag to check that the config object actually has some data before continuing to execute the rest of configChanged().