Skip to content

SL Cloud Migration Update November 2025 #29477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
blauerPCL wants to merge 20 commits into
base: main
Choose a base branch
from
Open

SL Cloud Migration Update November 2025 #29477

blauerPCL wants to merge 20 commits into from

Conversation

@blauerPCL
Copy link
Contributor

@blauerPCL blauerPCL commented Dec 1, 2025 •
edited
Loading

Summary

SL Cloud Migration Update for November 2025

  • New US extension that includes migration of IRS 1099 information
  • Update for GL Account Beginning Balances
  • Update to only migrate open AP and AR amounts from released and posted documents
  • Update for blank SL subaccount segments
  • Update for dimension shortcuts in General Ledger Setup

This PR replaces closed PRs 29378 and 29394.

Work Item(s)

Fixes #
AB#575741
AB#609658
AB#612598

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Dec 1, 2025
This was referenced Dec 2, 2025
Closed
Closed
@blauerPCL blauerPCL changed the title [DRAFT] SL Cloud Migration Update November 2025 SL Cloud Migration Update November 2025 Dec 2, 2025
@blauerPCL blauerPCL marked this pull request as ready for review December 2, 2025 04:30
@blauerPCL blauerPCL requested a review from a team as a code owner December 2, 2025 04:30
@blauerPCL blauerPCL requested a review from dcenic December 2, 2025 04:30
@blauerPCL
Copy link
Contributor Author

blauerPCL commented Dec 2, 2025

@nikolakukrika This PR is now ready for code review. Thank you.

nikolakukrika
nikolakukrika previously approved these changes Jan 10, 2026
View reviewed changes
nikolakukrika
nikolakukrika reviewed Jan 10, 2026
View reviewed changes
ventselartur
ventselartur reviewed Jan 20, 2026
View reviewed changes
Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al Outdated
if not IRS1099FormBox.FindFirst() then
exit(false);

IRS1099VendorFormBoxSetup.Validate("Period No.", Format(TaxYear));
Copy link

@ventselartur ventselartur Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to validate if IRS Reporting Period record exists before assigning the Fortmat(TaxYear) value to the "Period No." field

Copy link
Contributor Author

@blauerPCL blauerPCL Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a check to validate that the IRS Reporting Period exists before assigning the Fortmat(TaxYear) value to the "Period No." field

if not IRSReportingPeriod.Get(Format(TaxYear)) then
exit(false);

ventselartur
ventselartur reviewed Jan 20, 2026
View reviewed changes
Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al
IRS1099VendorFormBoxSetup: Record "IRS 1099 Vendor Form Box Setup";
IRS1099FormBox: Record "IRS 1099 Form Box";
begin
IRS1099FormBox.SetRange("No.", IRS1099Code);
Copy link

@ventselartur ventselartur Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to set filter for period as well

Copy link
Contributor Author

@blauerPCL blauerPCL Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added IRS1099FormBox.SetRange("Period No.", IRSReportingPeriod."No.");

ventselartur
ventselartur reviewed Jan 20, 2026
View reviewed changes
Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al Outdated
Comment on lines 463 to 466
if IRS1099FormBox.FindFirst() then
GenJournalLine.Validate("IRS 1099 Form No.", IRS1099FormBox."Form No.");

GenJournalLine.Validate("IRS 1099 Form Box No.", IRS1099Code);
Copy link

@ventselartur ventselartur Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure i understand why we only validate "IRS 1099 Form No." if IRS1099FormBox exists, but "IRS 1099 Form Box No." regardless. Should the second Validate call also be wrapper into the IF condition?

Copy link
Contributor Author

@blauerPCL blauerPCL Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored the code to validate the IRS 1099 Reporting Period, IRS 1099 Form No., IRS 1099 Form Box No., and IRS 1099 Reporting Amount fields if IRS1099ForBox exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikolakukrika nikolakukrika nikolakukrika left review comments

@ventselartur ventselartur ventselartur left review comments

@dcenic dcenic Awaiting requested review from dcenic dcenic is a code owner automatically assigned from microsoft/dynamics-365-business-central

At least 1 approving review is required to merge this pull request.

Assignees

@nikolakukrika nikolakukrika

Labels

Integration GitHub request for Integration area

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blauerPCL @nikolakukrika @ventselartur @JesperSchulz