Merged
Conversation
Sergio0694
reviewed
Feb 17, 2026
|
|
||
| <!-- | ||
| Default property values for 'cswinrtgen'. Not setting 'CsWinRTToolsDirectory' and | ||
| Default property values for cswinrt generators. Not setting 'CsWinRTToolsDirectory' and |
Member
There was a problem hiding this comment.
Suggested change
| Default property values for cswinrt generators. Not setting 'CsWinRTToolsDirectory' and | |
| Default property values for 'cswinrtinteropgen'. Not setting 'CsWinRTToolsDirectory' and |
Member
Author
There was a problem hiding this comment.
That was intentional, some of the properties below, especially the last couple, were common enough to be used by our other generators and are used in some cases rather than duplicating the properties.
Member
There was a problem hiding this comment.
Ah, I see. Then can you put 'cswinrt' in single quotes? Would make it clearer it specifically refers to those.
Member
Author
There was a problem hiding this comment.
Sure, probably will address this as part of my source generator fix PR.
Sergio0694
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.