ios_base::_Addstd: need to check last byte #5978
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wclog is not checked, it seems to be forgotten about when _Addstd is called.
cpplearner
reviewed
Dec 27, 2025
| void __CLRCALL_PURE_OR_CDECL ios_base::_Addstd(ios_base* _This) { // add standard stream to destructor list | ||
| _BEGIN_LOCK(_LOCK_STREAM) | ||
| for (_This->_Stdstr = 1; _This->_Stdstr < _Nstdstr; ++_This->_Stdstr) { | ||
| for (_This->_Stdstr = 1; _This->_Stdstr <= _Nstdstr; ++_This->_Stdstr) { |
Contributor
There was a problem hiding this comment.
This change seems unnecessary and even misleading. _This->_Stdstr should never be larger than _Nstdstr after the loop, but with <= the loop structure suggests that it could be.
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wclog is not checked, it seems to be forgotten about when _Addstd is called.