Fix good lints given by eslint-plugin-unicorn#55517
Closed
jakebailey wants to merge 51 commits intomicrosoft:mainfrom
Closed
Fix good lints given by eslint-plugin-unicorn#55517jakebailey wants to merge 51 commits intomicrosoft:mainfrom
jakebailey wants to merge 51 commits intomicrosoft:mainfrom
Conversation
[git-generate] npm ci npx hereby lint --fix || true npx dprint fmt
typescript-bot
added
Author: Team
For Uncommitted Bug
fatcerberus
reviewed
Aug 26, 2023
scripts/errorCheck.mjs
Outdated
| let g; | ||
| while (g = errRegex.exec(baseline)) { | ||
| const errCode = +g[1]; | ||
| const msg = keys.filter(k => messages[k].code === errCode)[0]; |
There was a problem hiding this comment.
This just seems like a weird pattern in general. Particularly since filter doesn't short-circuit.
Member
Author
There was a problem hiding this comment.
I don't disagree, I didn't write it, but I am fixing it 😅
src/compiler/commandLineParser.ts
Outdated
|
|
||
| function makePadding(paddingLength: number): string { | ||
| return Array(paddingLength + 1).join(" "); | ||
| return new Array(paddingLength + 1).join(" "); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
Though really I don't know why this isn't just .repeat.
Member
Author
|
@typescript-bot perf test this faster |
Collaborator
|
Heya @jakebailey, I've started to run the faster perf test suite on this PR at b1d2b24. You can monitor the build here. Update: The results are in! |
Collaborator
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not final; I'm not totally sure I want to add this dependency (it's kinda big).